fix: Kafka client resource leak #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sarama Kafka clients leak several resources (goroutines, metrics, connections) if not closed properly. A client is created and managed within the topic manager and therefore a topic manager will leak resources if not properly closed. Topic Managers are created in two places: 1. When calling `prepareTopics` while instantiating a new processor. 2. Within `processor.Run`. The first of these is correctly closed, but the latter was not. Closing the second instance should ensure underlying Sarama resources are appropriate cleaned up when a processor stops.
|
Happy to help! If there's anything else I can do to help get this over the line and released, please let me know 🙏🏼. It was actively affecting some of our workloads, so we'd love to upgrade to a patched version. |
|
Just checking if there's a planned release with this fix in the near future? Don't mean to rush a release, just trying to figure out if we should wait for a release or publish or own patched version. |
|
@jalaziz FYI fix is contained in this release: https://github.com/lovoo/goka/releases/tag/v1.1.13 Thanks again for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sarama Kafka clients leak several resources (goroutines, metrics, connections) if not closed properly. A client is created and managed within the topic manager and therefore a topic manager will leak resources if not properly closed.
Topic Managers are created in two places:
prepareTopicswhile instantiating a new processor.processor.Run.The first of these is correctly closed, but the latter was not. Closing the second instance should ensure underlying Sarama resources are appropriate cleaned up when a processor stops.