8000 [P4Testgen] Add target-specifc P4Testgen gtests by fruffy-bfn · Pull Request #4093 · p4lang/p4c · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[P4Testgen] Add target-specifc P4Testgen gtests #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2023
Merged

[P4Testgen] Add target-specifc P4Testgen gtests #4093

merged 3 commits into from
Aug 7, 2023

Conversation

fruffy-bfn
Copy link
Contributor
@fruffy-bfn fruffy-bfn commented Aug 3, 2023 •
edited
Loading

Proof-of-concept demonstrating how to add P4Testgen-extension-specific GTests.
@nikil21

@fruffy-bfn fruffy-bfn force-pushed the fruffy/p4tools_gtest branch 4 times, most recently from 84bfcab to cb7bfea Compare August 3, 2023 16:54
@fruffy-bfn fruffy-bfn force-pushed the fruffy/p4tools_gtest branch from cb7bfea to d4c6386 Compare August 6, 2023 19:30
@fruffy fruffy marked this pull request as ready for review August 7, 2023 07:56
@jafingerhut
Copy link
Contributor

This one seems best to request review from other p4testgen devs, perhaps?

@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Aug 7, 2023
jnfoster
jnfoster approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor
@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy fruffy merged commit 7f53a12 into p4lang:main Aug 7, 2023
@fruffy-bfn fruffy-bfn deleted the fruffy/p4tools_gtest branch August 7, 2023 14:31
@fruffy fruffy mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnfoster jnfoster jnfoster approved these changes

@fruffy fruffy Awaiting requested review from fruffy

@pkotikal pkotikal Awaiting requested review from pkotikal

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fruffy-bfn @jafingerhut @jnfoster @fruffy
0