Enable automatic release on version change #2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6ccc3c to
49647ca
Compare
|
Is this work discussed in any meeting and asked to do? I can always use a git commit id to pull a branch for p4c. |
I'm sorry, I should have mentioned this. We discussed it on the PSA meeting. |
mihaibudiu
reviewed
Jun 28, 2021
There was a problem hiding this comment.
@fruffy can you please review these files? You have written our github actions automation.
Thank you.
fruffy
requested changes
Jun 28, 2021
This commit create a VERSION file that can be used to obtain the current version of P4C. The current version string "1.2.0+g202103291035~a69e52" contains a semantic version, date and current git commit. However, the date makes sense only in packages. Building the same P4C compiler code on a different day should not result in a different version name. The current git commit is automatically from the git history. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
49647ca to
ba33f2f
Compare
This GitHub action doesn't create a release, it only tests if a static build works on Ubuntu 20.04. Thus, using the name "static build" looks more accurately describes what it does. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
ba33f2f to
967dbcb
Compare
This GitHub action creates a release in GitHub every time the Version.txt file has been changed. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
967dbcb to
6937349
Compare
fruffy
approved these changes
Jun 29, 2021
usha1830
pushed a commit
to usha1830/p4c
that referenced
this pull request
Aug 7, 2021
* Use version file This commit create a VERSION file that can be used to obtain the current version of P4C. The current version string "1.2.0+g202103291035~a69e52" contains a semantic version, date and current git commit. However, the date makes sense only in packages. Building the same P4C compiler code on a different day should not result in a different version name. The current git commit is automatically from the git history. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org> * ci: rename 'release' action to 'static-build' This GitHub action doesn't create a release, it only tests if a static build works on Ubuntu 20.04. Thus, using the name "static build" looks more accurately describes what it does. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org> * Enable automatic releases This GitHub action creates a release in GitHub every time the Version.txt file has been changed. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables automatic GitHub release (and git tag creation) every time the version of P4C has been changed.