fix overzealous replace in wrappers pathnames #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapper filenames were generated by replacing ".c" with "_private.h". Unfortunately this matched anywhere in the string, causing problems if the path contained a directory containing the substring ".c". For instance, if box64 is compiled in a '.cache' directory (as AUR helpers like to do, see ptitSeb#144), the directory name was inadvertently mangled into '_private.hache'. Fix this by restricting the match to the end of the string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper filenames were generated by replacing ".c" with "_private.h". Unfortunately this matched anywhere in the string, causing problems if the path contained a directory containing the substring ".c". For instance, if box64 is compiled in a '.cache' directory (as AUR helpers like to do, see #144), the directory name was inadvertently mangled into '_private.hache'.
Fix this by restricting the match to the end of the string.