[RV64_DYNAREC] Fixed 66 0F B6 MOVZX opcode #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does that means it's not ready to merge yet? |
|
Ready to merge. I've tested wine explorer.exe and Flatout, and both are working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After tedious bisecting with BOX64_NODYNAREC, I found that this opcode was not correctly implemented. However, a strange SIGBUS error pops up when I'm trying to run YuanShen.exe (Genshin Impact) with this patch. If the fix is only applied to VMP areas (by checking
addrin dynarec), the program can produce a meaningful "A debugger has been found running in your system.\nPlease, unload it from memory and restart your program." message instead of garbage as before.