8000 Remove the flags adjustment in `GO_TRACE` for RISC-V 64 by Coekjan · Pull Request #1663 · ptitSeb/box64 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove the flags adjustment in GO_TRACE for RISC-V 64 #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

Remove the flags adjustment in GO_TRACE for RISC-V 64 #1663

merged 1 commit into from
Jul 10, 2024

Conversation

Coekjan
Copy link
Contributor
@Coekjan Coekjan commented Jul 9, 2024

If I am doing the correct thing, this could closes #1661 .

@ptitSeb
Copy link
Owner
ptitSeb commented Jul 9, 2024

If I am doing the correct thing, this could closes #1661 .

This PR is actually correct because the ADJUST TO/FROM on Bit11 operation is already done in call_c when saveflags is "1", wich is the case here. I'll merge the PR tomorrow, as I have just released a new version.

@ptitSeb ptitSeb merged commit 4eca496 into ptitSeb:main Jul 10, 2024
34 checks passed
@Coekjan Coekjan deleted the flags branch July 11, 2024 13:04
Javier97sm pushed a commit to Javier97sm/box64 that referenced this pull request Aug 16, 2024
@Coekjan @Javier97sm
Remove the flags adjustment in GO_TRACE for RISC-V 64 (ptitSeb#1663)
0cce5ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected Dynarec-Interpreter Difference on cmp Instruction
2 participants
@Coekjan @ptitSeb
0