8000 [LA64_DYNAREC] Added AES opcodes by xiangzhai · Pull Request #2122 · ptitSeb/box64 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[LA64_DYNAREC] Added AES opcodes #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2024
Merged

[LA64_DYNAREC] Added AES opcodes #2122

merged 2 commits into from
Dec 7, 2024

Conversation

xiangzhai
Copy link
Contributor

Hi,

Please review my patch.

Thanks,
Leslie Zhai

ksco
ksco requested changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator
@ksco ksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RV64 implementations does not always apply to LA64, I believe there is no need to do this while you have LSX at hand.

@ksco
Copy link
Collaborator
ksco commented Dec 7, 2024

Check how ARM64 did it, and adapt it to LA64.

@xiangzhai xiangzhai requested a review from ksco December 7, 2024 07:50
ksco
ksco approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator
@ksco ksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better.

@xiangzhai
Copy link
Contributor Author

Thanks!

@ptitSeb ptitSeb merged commit eb299f5 into ptitSeb:main Dec 7, 2024
27 checks passed
@xiangzhai xiangzhai deleted the la64_dynarec_aes branch December 12, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksco ksco ksco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiangzhai @ksco @ptitSeb
0