8000 [RV64_DYNAREC] Optimize push/pop with xtheadmemidx by ksco · Pull Request #2150 · ptitSeb/box64 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[RV64_DYNAREC] Optimize push/pop with xtheadmemidx #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

ksco
Copy link
Collaborator
@ksco ksco commented Dec 13, 2024

No description provided.

@ptitSeb
Copy link
Owner
ptitSeb commented Dec 13, 2024

Some tests (idiv_32 and tlsData_32) seems to fail on box32 build. But not all the time?

@ksco
Copy link
Collaborator Author
ksco commented Dec 13, 2024

Some tests (idiv_32 and tlsData_32) seems to fail on box32 build. But not all the time?

The 11th run failed, which is BOX64_DYNAREC_TEST=1 QEMU_CPU=thead-c906 ctest $CTEST_OPTIONS -E nocosim.
... I reproduced this issue locally.
... Okay, fixed.

Glad that the verbose CI is not just a waste of power, it actually helps ;)

@ptitSeb
Copy link
Owner
ptitSeb commented Dec 13, 2024

Oh, there was some sign extension, I see.
But now, I'm a bit woring of the POP1_16 fix. Is RSP will be truncated to 16bits now?

@ksco
Copy link
Collaborator Author
ksco commented Dec 13, 2024

Oh, there was some sign extension, I see. But now, I'm a bit woring of the POP1_16 fix. Is RSP will be truncated to 16bits now?

nah, the addition is always full-sized, just like an ADDI.

@ptitSeb ptitSeb merged commit 4b4c014 into ptitSeb:main Dec 13, 2024
27 checks passed
@ksco ksco deleted the memidx branch December 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0