[GDBJIT] Display DynaRec info in source file #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ptitSeb
reviewed
Dec 20, 2024
ptitSeb
reviewed
Dec 20, 2024
ptitSeb
reviewed
Dec 20, 2024
| if (!box64_dynarec_dump && !box64_dynarec_gdbjit) return; | ||
|
|
||
| static char buf[512]; | ||
| int length = sprintf(buf, "barrier=%d state=%d/%d/%d(%d:%d->%d:%d), %s=%X/%X, use=%X, need=%X/%X, sm=%d(%d/%d)", |
There was a problem hiding this comment.
were are the colors for regular dump (because there was some color changes in the dump info)?
why not use a have_color variable instead?
There was a problem hiding this comment.
It's kept down below, see #2179 (comment)
ksco
commented
Dec 20, 2024
Comment on lines
+761
to
+762
| (box64_dynarec_dump > 1) ? "\e[32m" : "", | ||
| (void*)(dyn->native_start + dyn->insts[ninst].address), dyn->insts[ninst].size / 4, ninst, buf, (box64_dynarec_dump > 1) ? "\e[m" : ""); |
There was a problem hiding this comment.
@ptitSeb Colors are kept here.
ptitSeb
reviewed
Dec 20, 2024
ptitSeb
reviewed
Dec 20, 2024
| dynarec_log(LOG_NONE, "->%s", getCacheName(dyn->insts[ninst].n.neoncache[ii].t, dyn->insts[ninst].n.neoncache[ii].n)); | ||
| } | ||
| if (memcmp(dyn->insts[ninst].n.neoncache, dyn->n.neoncache, sizeof(dyn->n.neoncache))) { | ||
| length += sprintf(buf + length, " %s(Change:", (box64_dynarec_dump > 1) ? "\e[1;91m" : ""); |
There was a problem hiding this comment.
you get color here, even for gdbjit stuffs. Is that ok?
There was a problem hiding this comment.
Unless one uses DUMP=2 and GDBJIT=1 at the same time, which does not make much sense, there won't be any color, not sure if there is a better way to do this.
ptitSeb
reviewed
Dec 20, 2024
| if(dyn->insts[ninst].n.combined1 || dyn->insts[ninst].n.combined2) | ||
| dynarec_log(LOG_NONE, " %s:%d/%d", dyn->insts[ninst].n.swapped?"SWP":"CMB", dyn->insts[ninst].n.combined1, dyn->insts[ninst].n.combined2); | ||
| dynarec_log(LOG_NONE, "%s\n", (box64_dynarec_dump>1)?"\e[m":""); | ||
| length += sprintf(buf + length, ")%s", (box64_dynarec_dump > 1) ? "\e[0;32m" : ""); |
There was a problem hiding this comment.
same, color attribute again here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.