8000 Fixed an edge case in `rb_unset` by rajdakin · Pull Request #2562 · ptitSeb/box64 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed an edge case in rb_unset #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Fixed an edge case in rb_unset #2562

merged 1 commit into from
Apr 22, 2025

Conversation

rajdakin
Copy link
Collaborator

This PR fixes an edge case in rb_unset, where unsetting a range start:end with a node overlapping from the left would not unset the overlap:

before
+--------+---------+
|   42   | (unset) |
+--------+---------+
     ^ start       ^ end

after (bug)
+--------+---------+
|   42   | (unset) |
+--------+---------+
     ^ start       ^ end

after (fixed)
+----+-------------+
| 42 |   (unset)   |
+----+-------------+
     ^ start       ^ end

@ptitSeb ptitSeb merged commit cc6500b into ptitSeb:main Apr 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajdakin @ptitSeb
0