8000 Added new wrappings for libx11 by mhavu · Pull Request #274 · ptitSeb/box64 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added new wrappings for libx11 #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2022
Merged

Added new wrappings for libx11 #274

merged 3 commits into from
Apr 9, 2022

Conversation

mhavu
Copy link
Contributor
@mhavu mhavu commented Apr 9, 2022

Added some new wrappings for libx11 (including a fix for issue #272).

@mhavu
Copy link
Contributor Author
mhavu commented Apr 9, 2022

Oops. Seems like #272 had already been addressed. Anyhow, this PR includes some additional new wrappings.

@mhavu
Copy link
Contributor Author
mhavu commented Apr 9, 2022 •
edited
Loading

I forgot how PRs work in GitHub, and went on to add another commit to my fork. Of course it became a part of the open PR, which was not my intention. It wouldn't be a problem, though, had the X64 Release build not failed test11 for some reason. The latest commit includes a bunch of new GO wrappings for gtk, including the ones needed in fixing issue #254. However, the following missing GOM wrappings still remain:

GOM(gtk_tree_selection_selected_foreach, vFEpBp)
GOM(g_object_weak_ref, vFpBp)
GOM(gtk_tree_view_column_set_cell_data_func, vFEppBpB)

@ptitSeb ptitSeb merged commit aa4ec7b into ptitSeb:main Apr 9, 2022
@ptitSeb
Copy link
Owner
ptitSeb commented Apr 10, 2022

Will you do the 3 GOM wrapping or should I do them?

@mhavu
Copy link
Contributor Author
mhavu commented Apr 10, 2022 •
edited
Loading

I'd be glad to take a stab, but I haven't found any documentation on writing GOM wrappings, so it'll take me a while to figure out what should be done. For gtk_tree_view_column_set_cell_data_func(), it seems I could use gtk_cell_layout_set_cell_data_func() as an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhavu @ptitSeb
0