8000 fix(test): update progress steps in FastMCP test case by OR13 · Pull Request #116 · punkpeye/fastmcp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(test): update progress steps in FastMCP test case #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(test): update progress steps in FastMCP test case #116

wants to merge 1 commit into from
+1 −1

Conversation

OR13
Copy link
@OR13 OR13 commented Jun 15, 2025

No description provided.

@bianbianzhu
Copy link
Contributor
bianbianzhu commented Jun 15, 2025 •
edited
Loading

I think there's something wrong with the test case here. It is flaky. I saw onProgress got called both 3 times and 4 times in different runs, and this is probably the reason why this test case passed before.

But steps should be 4

@bianbianzhu bianbianzhu mentioned this pull request Jun 15, 2025
Open
@punkpeye
Copy link
Owner

Maybe add retry instead?

- test("reports multiple progress updates without buffering", async () => {
+ test("reports multiple progress updates without buffering", { retry: 3 }, async () => {

@punkpeye
Copy link
Owner

or change the condition to toBeOneOf([3, 4])

@punkpeye
Copy link
Owner
punkpeye commented Jun 15, 2025 •
edited
Loading

or fix the underlying flakiness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OR13 @bianbianzhu @punkpeye
0