feat: add authentication context to resources and resource templates #137
+670
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the FastMCP framework by passing authentication context to resource and resource template load functions, enabling resources to access user-specific data based on authentication state. ## Changes: ### Core Implementation: - Add generic type parameter `T extends FastMCPSessionAuth` to `Resource` and `ResourceTemplate` types - Update `Resource.load()` signature to accept optional `auth?: T` parameter - Update `ResourceTemplate.load()` signature to accept both args and optional `auth?: T` parameter - Pass `this.#auth` to resource load functions in `setupResourceHandlers()` - Update type definitions throughout to maintain type safety with generics ### Type System Fixes: - Fix TypeScript error TS2769 by casting session objects to `FastMCPSession<FastMCPSessionAuth>` in emit calls - Remove duplicate `Authenticate<T>` type definition - Ensure consistent generic type constraints across the codebase ### Tests: - Add "provides auth to resources" test to verify auth context is passed to resource.load() - Add "provides auth to resource templates" test to verify auth context is passed with template args - Add "provides auth to resource templates returning arrays" test to verify auth works with array returns - All tests follow existing patterns using vi.fn() mocks and HTTP Stream setup ## Breaking Changes: None - the auth parameter is optional, maintaining backward compatibility ## Use Cases: - Resources can now filter or customize content based on user permissions - Resource templates can generate user-specific content - Authentication state can be used for access control within resources 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Thank you for your contribution. Please ensure that all checks are passing. |
|
Many apologies, fixed the lint issues. Did you have any issues with the changes? |
… load - Make ArgumentValueCompleter generic to accept optional auth parameter - Changed signature from (value: string) => Promise<Completion> - To: (value: string, auth?: T) => Promise<Completion> - Update Prompt load method to accept optional auth parameter - Changed signature to include auth?: T parameter - Pass auth context when calling prompt.load() - Propagate generic type parameter T through all related types: - InputPromptArgument<T> - Prompt<T> - PromptArgument<T> - ResourceTemplate<T> - ResourceTemplateArgument<T> - Update complete functions to pass auth context to completers - Prompt argument completers now receive auth - Resource template argument completers now receive auth - Fix TypeScript errors by casting session to FastMCPSession<FastMCPSessionAuth> in emit calls to ensure type safety with StrictEventEmitter - Add comprehensive test coverage for auth context propagation: - Auth passed to resources during load - Auth passed to resource templates during load - Auth passed to resource templates returning arrays - Auth passed to prompt argument completion functions - Auth passed to prompt load functions - Auth passed to resource template argument completion functions - Update eslint config to ignore dist/** directory 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
@punkpeye - I expanded the availability of auth to prompts and argument loaders. I'm building an MCP that needs these capabilities. Let me know if it's too much, I'd be happy to back out the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the FastMCP framework by passing authentication context to resource and resource template load functions, enabling resources to access user-specific data based on authentication state.
Changes:
Core Implementation:
T extends FastMCPSessionAuthtoResourceandResourceTemplatetypesResource.load()signature to accept optionalauth?: TparameterResourceTemplate.load()signature to accept both args and optionalauth?: Tparameterthis.#authto resource load functions insetupResourceHandlers()Tests:
Breaking Changes:
None - the auth parameter is optional, maintaining backward compatibility
Use Cases:
🤖 Generated with Claude Code