Fix trait selection requiring extra key press to update #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix but it was annoying me :) To search by traits on the rankings screen...
Before the change:
After the change:
Steps 1)-3), but now it updates automatically (no need for step 4).
Technical:
There are multiple poke-search's on the screen (some hidden).
We were grabbing all of them and triggering updates on all of them, so that by the time we ended up at
submitSearchQuery, we had the wrong target, so applied the visual update to the wrong poke-search. To the user it appears that the screen didn't update automatically. Now, we will grab the poke-search that was clicked on, so that we always update visuals in the correct place.Tested on both the ranking screen, and the team builder ("select alternatives") screen.