Use query_port in async_query() calls #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on upstream commit 8202888
PerchunPak
approved these changes
May 13, 2025
ItsDrike
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily referring to commit 8202888.
Changes
Currently,
query()makes use of thequery_portvalue, butasync_query()does not.This PR introduces a small change to ensure that
async_query()also utilizes thequery_portvalue, making the behavior consistent withquery().Reasoning
The change ensures that the
async_query()function behaves in a similar manner toquery(). This should prevent potential issues for users who rely on thequery_portvalue for their queries.Tests
No additional tests should be needed, as the existing tests already cover the relevant scenarios. If further clarification or adjustments are required, I'd be happy to add them.