Add family relationships example #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstraints This commit adds a new example in tests/theorems/family_relationships.py that demonstrates: - Class hierarchies (Person as base class with Male/Female subclasses) - Various relationship classes (ParentOf, Sibling, Ancestor) - Logical constraints using implications (>>), conjunctions (&) and negation (~) - Transitivity and symmetry rules for relationships Also adds tests that verify the model works correctly with Z3Solver. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>8000
There was a problem hiding this comment.
PR Overview
This PR introduces an example for modeling family relationships using class hierarchies and logical constraints, along with tests to verify the model using the Z3Solver, and adds a developer guide file.
- New integration test for family relationships
- New module defining family relationship facts and axioms
- Addition of CLAUDE.md as a development guide
Reviewed Changes
| File | Description |
|---|---|
| tests/test_integrations/test_family_relationships.py | Contains tests that load the family relationships module and verify proofs |
| tests/theorems/family_relationships.py | Defines dataclasses and axioms for family relationships and logical constraints |
| CLAUDE.md | Provides development commands and style guidelines |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/test_integrations/test_family_relationships.py:36
- [nitpick] The comment 'Test negative assertions (parent relationships)' is misleading, as the assertions check that the ParentOf relationships exist rather than testing negative cases. Consider revising the comment to accurately describe what is being tested.
# Test negative assertions (parent relationships)
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
poetry run pytest tests/test_integrations/test_family_relationships.py -vto verify the test passes🤖 Generated with Claude Code