Add accessor and comments about CausalModel's CausalEstimator cache. #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of CausalEstimator objects stored in the CausalModel._estimator_cache dict. Accessor function gains test coverage and slightly simplifies logic via use in CausalModel.estimate_effect(). Signed-off-by: DAVID RAWLINSON <dave@causalwizard.app>
|
Also thanks for opening PR for this! Similar as for the one-hot-encoding, can you add a unit test for this? |
…mator, both CausalEstimator object references. Signed-off-by: DAVID RAWLINSON <dave@causalwizard.app>
|
Unit test added; checks that the relevant CausalEstimator objects exist and that they're the expected objects when retrieved from either accessor (via CausalEstimate.estimator or CausalModel.get_estimator()). |
|
Unsure why the CI tests failed, that part of the code is untouched and they all pass locally. Is this a build issue? |
Yea its an unrelated issue of a flaky unit test. Don't worry, I will re-run it. |
|
Thankyou! |
amit-sharma
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an accessor and comments explaining the expected lifecycle and use of CausalEstimator objects stored in the CausalModel._estimator_cache dict. Accessor function gains test coverage and slightly simplifies logic via use in CausalModel.estimate_effect().
See issue #1071