8000 Add node name property by ogsadmin · Pull Request #131 · pycollada/pycollada · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add node name property #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 19, 2022
Merged

Add node name property #131

merged 8 commits into from
Oct 19, 2022

Conversation

ogsadmin
Copy link
Contributor

Tried my best (not being a python programmer) to add the node name property to the Node class and not break backwards compatibility.
The tests specified in the github actions pass, please review.

@ogsadmin
Copy link
Contributor Author

This pull request is about implementing issue #130.

jterrace
jterrace requested changes Oct 18, 2022
View reviewed changes
@ogsadmin
Copy link
Contributor Author

Seems like the tests pass now - can you take another look?

jterrace
jterrace reviewed Oct 19, 2022
View reviewed changes
@jterrace jterrace merged commit 3e78d40 into pycollada:master Oct 19, 2022
@jterrace jterrace mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jterrace jterrace jterrace requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogsadmin @jterrace
0