Change opaque surface test to use SDL_ISPIXELFORMAT_ALPHA() macro #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 28, 2020 19:43
This is because if a destination surface has no pixel alpha and surface alpha is set on it it's blend mode will no longer be SDL_BLENDMODE_NONE. However, we still want to treat it as an opaque surface because it will have 0 pixel alpha and we can't use the optimised 'no surface alpha' blitter which assumes two surfaces with pixel alpha.
Fails prior to this PR, passes afterwards.
Previously they were sent to SDL 2 but I think it's more proper just to do them more slowly with our alpha blitter. Shouldn't effect many blits anyway as self blits are rare. I previously excluded them just because the crash the SSE 2 versions which wasn't a good reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because if a destination surface has no pixel alpha and surface alpha is set on it it's blend mode will no longer be SDL_BLENDMODE_NONE.
However, we still want to treat it as an opaque destination surface from the blitter's perspective because it will have 0 pixel alpha and we can't use the optimised 'no surface alpha' blitter which assumes two surfaces with pixel alpha to do it's thing.
This fixes the menu bug in FlyBoy.