8000 Add deprecation warning when draw.aaline is called with blend=False by zoldalma999 · Pull Request #2261 · pygame/pygame · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add deprecation warning when draw.aaline is called with blend=False #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll o 8000 ccasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 19, 2020
Merged

Add deprecation warning when draw.aaline is called with blend=False #2261

merged 4 commits into from
Dec 19, 2020

Conversation

zoldalma999
Copy link
Contributor
@zoldalma999 zoldalma999 commented Oct 28, 2020 •
edited
Loading

@MyreMylar
Copy link
Contributor

Should link the general discussion issue on these:

#2197

My final verdict on DeprecationWarnings is that we should start using them from 2.0.0 onwards, they don't spam, there are options to filter them if the user doesn't care at all and it is better for us to provide feedback before changing any APIs. Since the focus post 2.0.0 is slightly less on compatibility with the past, and more on useful features to catch pygame up with the modern world DeprecationWarnings seem like a useful tool in that box.

I won't approve this for now in case everyone else is against, but I'm for them in general and I think the way it's done in this PR is a good method.

Starbuck5
Starbuck5 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor
@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody seems to have come out against deprecation warnings, and it has been a while.
These changes look good to me.

@Starbuck5
Copy link
Contributor
Starbuck5 commented Dec 19, 2020 •
edited
Loading

@illume - I think this is ready to merge.

After merging this I was thinking it would be good to open an issue that reminds us to actually deprecate this and set_system_cursor() by 2.2.

illume
illume approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member
@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@illume illume mentioned this pull request Dec 19, 2020
Open
@illume
Copy link
Member
illume commented Dec 19, 2020

Thanks @Starbuck5 . I created an issue here: #2405 with the milestone 2.2.

@illume illume merged commit dab35ac into pygame:main Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zoldalma999 @MyreMylar @Starbuck5 @illume
0