8000 backwards compatible env vars, SDL_VIDEODRIVER=windib, SDL_AUDIODRIVER=pulse or dsound by illume · Pull Request #2292 · pygame/pygame · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

backwards compatible env vars, SDL_VIDEODRIVER=windib, SDL_AUDIODRIVER=pulse or dsound #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000 Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2020
Merged

backwards compatible env vars, SDL_VIDEODRIVER=windib, SDL_AUDIODRIVER=pulse or dsound #2292

merged 2 commits into from
Nov 7, 2020

Conversation

illume
Copy link
Member
@illume illume commented Oct 31, 2020 •
edited
Loading

For #2282

Otherwise apps that use SDL_VIDEODRIVER=windib or SDL_AUDIODRIVER=pulse or dsound will fail when using SDL2.

MyreMylar
MyreMylar reviewed Oct 31, 2020
View reviewed changes
@illume illume force-pushed the windib branch 2 times, most recently from 2bc4c2b to 9cc24c9 Compare November 7, 2020 11:41
@illume illume marked this pull request as ready for review November 7, 2020 11:42
@illume
Copy link
Member Author
illume commented Nov 7, 2020

(note, I cancelled the travis build, it didn't fail).

ankith26
ankith26 approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor
@ankith26 ankith26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me ;)
Cheers!

@illume
Copy link
Member Author
illume commented Nov 7, 2020 •
edited
Loading

I fixed the SDL_strncasecmp usage, and added backwards compatible SDL_AUDIODRIVER names too.

@illume illume changed the title windib video driver with SDL2 should not fail on windows. backwards compatible env vars, SDL_VIDEO_DRIVER=windib, SDL_AUDIO_DRIVER=pulse or dsound Nov 7, 2020
@illume illume linked an issue Nov 7, 2020 that may be closed by this pull request
SDL_VIDEODRIVER windib should not fail #2282
Closed
@illume illume changed the title backwards compatible env vars, SDL_VIDEO_DRIVER=windib, SDL_AUDIO_DRIVER=pulse or dsound backwards compatible env vars, SDL_VIDEODRIVER=windib, SDL_AUDIODRIVER=pulse or dsound Nov 7, 2020
@illume illume merged commit 6378c7f into main Nov 7, 2020
@illume illume deleted the windib branch November 7, 2020 16:02
@illume illume added this to the 2.0.1 milestone Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar left review comments

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

SDL_VIDEODRIVER windib should not fail
3 participants
@illume @MyreMylar @ankith26
0