Pathlib support for most pygame functions #2366
Conversation
|
Again.... |
|
I did a bit of local testing. And the functions accept pathlib objects. |
|
Looks like appveyor is not in a mood to work today. EDIT: pygame.org appears to be down ATM, that explains appveyor failures EDIT: also Manylinux and Mac builds are happy. So only code-reviews and docs are left |
There was a problem hiding this comment.
Cool. A very nice improvement. Thanks 👍
I reran the appveyor jobs after fixing the website and they passed :)
I haven't reviewed the C code in great detail, but it looks good at first glance.
Could probably do with tests for loading images, and sounds. But they could come later IMHO. Leaving out python 2 support is fine IMHO... if someone else wants to add support for pathlib/pathlib2 backport they can later. Docs and types could also come later. We can leave the issue open with these points.
If you're happy with it, we can merge this in now.
|
Yup. We can merge it anytime. And yeah. I would like to to docs/types. If you would like to merge this, I can open a separate PR. Whichever is convenient for you :) |
This PR adds Pathlib support to most pygame functions where a file is taken in as an argument. This includes pygame.image, pygame.mixer, pygame.music, pygame.font, pygame.ftfont and pygame.freetype (basically, wherever the internal function pg_EncodeString is called)
It was a relatively simple addition, yet much needed as many people have asked for this.
There was a previous attempt to do this, but that PR did not work on py 3.5. This PR makes sure it does.
Issues this PR aims to close are #1129 #1635
Unit tests and docs coming soon :)