Account for mixer.init()/pre_init() returning more channels than asked #2372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of channels requested in mixer.init() is a request and more channels may be returned than asked for. This PR changes the tests to reflect that with a assertEqual() swapped out for assertGreaterEqual().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of channels requested in mixer.init() is a request and more channels may be returned than asked for. This PR changes the tests to reflect that with an assertEqual() swapped out for assertGreaterEqual(). With this PR the test pass locally again on my version of windows. Returning more channels than asked for can't really be considered a failure.
fixes #2364