Fix warnings, make warnings error on CI #2919

ankith26 · 2021-12-16T07:58:06Z

PR to close #1316

Fixes some compiler warnings (and also skips some warnings) and make warnings error on CI

Also fixes most MSVC static analyzer warnings (all except ones in pygame.mask) and those too error on CI

Some skipped warnings (todos for future)

GCC on linux complains about unused-but-set-variable while compiling freetype. There is a complex macro system here that caused the warning, that seemed hard to fix so I skipped it for now
MSVC static analyzer complains while compiling pygame.mask about possible buffer overflows, and I'm not sure whether it's a false report or not here, so I skipped it here for now

illume · 2021-12-20T18:10:47Z

Very good! It's my understanding that static analysis errors

often cause bugs when the warnings are fixed
often point to areas of code that are smelly in some way other than the warning they fix

So I want to take a bit more time than usual to review these by testing out the code in a debugger and such, as well as having a look at code/docs/tests around the areas fixed.

Probably the two open tasks could be turned into two new issues?

ankith26 · 2021-12-23T08:58:49Z

For the most part I'm fairly confident this PR is safe, but yeah I'd appreciate if you and/or anyone else could do a bit more checking around pixelarray and buffer stuff, as I'm not too sure about those fixes

src_c/base.c

src_c/bitmask.c

src_c/camera_v4l2.c

src_c/display.c

src_c/event.c

src_c/rwobject.c

.github/workflows/cppcheck.yml

illume

👍 TMNT 👀🥷🐢

thanks heaps

saper · 2023-06-06T01:52:27Z

src_c/rwobject.c

+#else
+#define PG_LSEEK lseek64
+#endif
+


Proposed #3898 to improve this on non-glibc platforms.

ankith26 force-pushed the ankith26-werror branch 4 times, most recently from 5aeb6c4 to 930fc72 Compare December 16, 2021 12:18

ankith26 marked this pull request as draft December 16, 2021 12:30

ankith26 force-pushed the ankith26-werror branch from 930fc72 to d104b38 Compare December 16, 2021 15:54

ankith26 added this to the 2.1.1 milestone Dec 17, 2021

ankith26 force-pushed the ankith26-werror branch 3 times, most recently from 5a49847 to 28c8a66 Compare December 17, 2021 04:38

Starbuck5 removed this from the 2.1.1 milestone Dec 17, 2021

ankith26 force-pushed the ankith26-werror branch from 110742e to 64e26a6 Compare December 18, 2021 05:59

ankith26 marked this pull request as ready for review December 18, 2021 06:08

ankith26 force-pushed the ankith26-werror branch 3 times, most recently from 2def78c to f838b7f Compare December 18, 2021 11:32

ankith26 marked this pull request as draft December 18, 2021 11:55

ankith26 force-pushed the ankith26-werror branch from f838b7f to 52ef758 Compare December 18, 2021 13:05

ankith26 marked this pull request as ready for review December 18, 2021 13:43

ankith26 added this to the 2.1.1 milestone Dec 18, 2021

ankith26 force-pushed the ankith26-werror branch 2 times, most recently from 47e37fe to 7bcf409 Compare December 19, 2021 12:55

illume added bug Linters Related to code linting issues or solutions needs-review labels Dec 22, 2021