10000 Aiohttp server wrapper by adtyavrdhn · Pull Request #1131 · pydantic/logfire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Aiohttp server wrapper #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jun 12, 2025
Merged

Aiohttp server wrapper #1131

merged 36 commits into from
Jun 12, 2025

Conversation

adtyavrdhn
Copy link
Contributor

Fixes #995

Adds a wrapper for Open Telemetry's AioHttpServerInstrumentor

@hyperlint-ai Hyperlint AI
Copy link
Contributor
hyperlint-ai bot commented Jun 9, 2025

PR Change Summary

Introduced a wrapper for Open Telemetry's AioHttpServerInstrumentor, allowing instrumentation of AioHTTP servers.

  • Added support for AioHTTP server instrumentation with logfire.instrument_aiohttp_server() method.
  • Included a minimal example for AioHTTP server usage in the documentation.
  • Updated the AIOHTTP Client section to reflect the new server instrumentation feature.

Modified Files

  • docs/integrations/http-clients/aiohttp.md
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@codecov Codecov
Copy link
codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

adtyavrdhn
adtyavrdhn commented Jun 10, 2025
View reviewed changes
alexmojaki
alexmojaki reviewed Jun 10, 2025
View reviewed changes
alexmojaki
alexmojaki reviewed Jun 10, 2025
View reviewed changes
alexmojaki
alexmojaki reviewed Jun 10, 2025
View reviewed changes
alexmojaki
alexmojaki requested changes Jun 12, 2025
View reviewed changes
Copy link
Contributor
@alexmojaki alexmojaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add minimal tests similar to tests/otel_integrations/test_aiohttp_client.py

alexmojaki
alexmojaki requested changes Jun 12, 2025
View reviewed changes
@adtyavrdhn adtyavrdhn requested a review from alexmojaki June 12, 2025 14:34
alexmojaki
alexmojaki requested changes Jun 12, 2025
View reviewed changes
Copy link
Contributor
@alexmojaki alexmojaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix remaining mentions of logfire[aiohttp] in the repo

@adtyavrdhn adtyavrdhn requested a review from alexmojaki June 12, 2025 17:15
@alexmojaki alexmojaki merged commit db75470 into pydantic:main Jun 12, 2025
18 checks passed
@alexmojaki
Copy link
Contributor

Thanks! This is released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmojaki alexmojaki Awaiting requested review from alexmojaki

Assignees
No one assigned
Labels
awaiting author revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for aiohttp server
2 participants
@adtyavrdhn @alexmojaki
0