8000 Don't generate URLs for custom errors by dmontagu · Pull Request #586 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Don't generate URLs for custom errors #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

dmontagu
Copy link
Collaborator
@dmontagu dmontagu commented May 5, 2023

No description provided.

Copy link
Member
@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great.

@codspeed-hq
Copy link
codspeed-hq bot commented May 5, 2023

CodSpeed Performance Report

Merging #586 no-custom-error-urls (ea544b4) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 114 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@codecov-commenter
Copy link

Codecov Report

Merging #586 (ea544b4) into main (4767abf) will increase coverage by 0.08%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
+ Coverage   94.12%   94.20%   +0.08%     
==========================================
  Files          96       96              
  Lines       13021    13046      +25     
  Branches       24       24              
==========================================
+ Hits        12256    12290      +34     
+ Misses        759      750       -9     
  Partials        6        6              
Impacted Files Coverage Δ
src/errors/validation_exception.rs 93.42% <100.00%> (+0.20%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4767abf...ea544b4. Read the comment docs.

@dmontagu dmontagu merged commit 403cce7 into main May 5, 2023
@dmontagu dmontagu deleted the no-custom-error-urls branch May 5, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0