8000 RootModel by samuelcolvin · Pull Request #592 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

RootModel #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2023
Merged

RootModel #592

merged 3 commits into from
May 5, 2023

Conversation

samuelcolvin
Copy link
Member
@samuelcolvin samuelcolvin commented May 5, 2023 •
edited
Loading

part of pydantic/pydantic#5498

Selected Reviewer: @dmontagu

@codspeed-hq
Copy link
codspeed-hq bot commented May 5, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #592 root-model (4be5870) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 114 untouched benchmarks

🆕 1 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main root-model Change
🆕 test_core_root_model N/A 112.2 µs N/A

@codecov-commenter
Copy link
codecov-commenter commented May 5, 2023 •
edited
Loading

Codecov Report

Merging #592 (4be5870) into main (dbff171) will increase coverage by 0.02%.
The diff coverage is 98.64%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   94.17%   94.20%   +0.02%     
==========================================
  Files          96       96              
  Lines       13069    13104      +35     
  Branches       24       24              
==========================================
+ Hits        12308    12344      +36     
+ Misses        755      754       -1     
  Partials        6        6
Impacted Files Coverage Δ
src/validators/model.rs 98.80% <98.63%> (+0.64%) ⬆️
pydantic_core/core_schema.py 96.96% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbff171...4be5870. Read the comment docs.

@samuelcolvin
Copy link
Member Author

please review.

@samuelcolvin samuelcolvin assigned dmontagu and unassigned adriangb May 5, 2023
adriangb
adriangb reviewed May 5, 2023
View reviewed changes
@dmontagu dmontagu merged commit b863be7 into main May 5, 2023
@dmontagu dmontagu deleted the root-model branch May 5, 2023 21:33
@samuelcolvin samuelcolvin mentioned this pull request May 10, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb left review comments

@dmontagu dmontagu dmontagu approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelcolvin @codecov-commenter @adriangb @dmontagu
0