Remove warning for mutable default #594
Conversation
|
Well, there are tests failing now on CI. 🤷🏻♂️ |
CodSpeed Performance ReportMerging #594 Summary
|
|
Stupid — I didn't rebuild before running tests. So of course. I'll fix it |
|
There is nothing to fix. You could just leave the warning where it is maybe? I'd rather keep the warning which in an edge case misses some info than remove it completely. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 94.17% 94.17% -0.01%
==========================================
Files 96 96
Lines 13069 13064 -5
Branches 24 24
==========================================
- Hits 12308 12303 -5
Misses 755 755
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
|
(We discussed on slack but just adding note here for posterity:) The reason for removing the warning wasn't the bad error message — we concluded it was better behavior to not have this warning, because it will require a lot of code changes and forces users to go down code paths that are more likely to lead to confusion and/or bugs for non-advanced users. |
There was no test that failed when I deleted this code; I'm assuming it's okay if I don't add a test that it doesn't happenNeeded to rebuild, non-issue.