10000 Add JsonOrPython validator and serializer by adriangb · Pull Request #598 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add JsonOrPython validator and serializer #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 10, 2023
Merged

Add JsonOrPython validator and serializer #598

merged 10 commits into from
May 10, 2023

Conversation

adriangb
Copy link
Member
@adriangb adriangb commented May 9, 2023 •
edited by pydantic-hooky bot
Loading

Selected Reviewer: @dmontagu

@codspeed-hq
Copy link
codspeed-hq bot commented May 9, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #598 json-or-python (1e38cb9) will not alter performances.

Summary

🔥 1 improvements
❌ 0 regressions
✅ 114 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main json-or-python Change
🔥 test_isinstance_json 31.3 µs 26.3 µs 15.98%

@adriangb
Copy link
Member Author
adriangb commented May 9, 2023

please review

This was referenced May 10, 2023
Merged
Merged
dmontagu
dmontagu approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator
@dmontagu dmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriangb adriangb enabled auto-merge (squash) May 10, 2023 13:28
@codecov-commenter
Copy link

Codecov Report

Merging #598 (1e38cb9) into main (027e679) will decrease coverage by 0.17%.
The diff coverage is 88.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   94.21%   94.04%   -0.17%     
==========================================
  Files          96       98       +2     
  Lines       13114    13177      +63     
  Branches       24       25       +1     
==========================================
+ Hits        12355    12392      +37     
- Misses        753      779      +26     
  Partials        6        6
Impacted Files Coverage Δ
src/input/input_json.rs 92.91% <ø> (-0.26%) ⬇️
src/input/input_python.rs 98.72% <ø> (-0.04%) ⬇️
src/input/mod.rs 100.00% <ø> (ø)
src/input/parse_json.rs 100.00% <ø> (+1.42%) ⬆️
src/serializers/shared.rs 89.65% <ø> (ø)
src/validators/json_or_python.rs 82.00% <82.00%> (ø)
src/serializers/type_serializers/json_or_python.rs 85.71% <85.71%> (ø)
pydantic_core/core_schema.py 96.87% <91.66%> (-0.10%) ⬇️
src/validators/mod.rs 98.51% <95.45%> (-0.01%) ⬇️
src/input/input_abstract.rs 85.29% <100.00%> (-2.59%) ⬇️
... and 5 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027e679...1e38cb9. Read the comment docs.

@adriangb adriangb merged commit c1e0111 into main May 10, 2023
@adriangb adriangb deleted the json-or-python branch May 10, 2023 13:47
@davidhewitt davidhewitt mentioned this pull request Aug 21, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriangb @codecov-commenter @dmontagu
0