Fix reversal of loc when building errors from Python #609
Conversation
|
Please review |
| /// Only ever called by ValidationError -> PyLineError to convert user input to our internal Location | ||
| /// Thus this expects the location to *not* be reversed and reverses it before storing it. | ||
| fn try_from(location: Option<&PyAny>) -> PyResult<Self> { |
There was a problem hiding this comment.
I think if we have things like this that are only ever called from one place it might be best to just implement them in that one place instead of a reusable trait to avoid confusion around this sort of implementation details stemming from how the trait ends up getting used.
CodSpeed Performance ReportMerging #609 Summary
|
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 94.25% 94.13% -0.13%
==========================================
Files 98 98
Lines 13188 13189 +1
Branches 25 25
==========================================
- Hits 12430 12415 -15
- Misses 752 768 +16
Partials 6 6
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Fixes #597
Selected Reviewer: @samuelcolvin