10000 fix for model subclass serialization in unions by samuelcolvin · Pull Request #632 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix for model subclass serialization in unions #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

fix for model subclass serialization in unions #632

merged 1 commit into from
May 25, 2023

Conversation

samuelcolvin
Copy link
Member
@samuelcolvin samuelcolvin commented May 25, 2023 •
edited
Loading

fix pydantic/pydantic#5839

Selected Reviewer: @dmontagu

@samuelcolvin samuelcolvin mentioned this pull request May 25, 2023
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #632 (fac81b1) into main (26fa27d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   94.04%   94.11%   +0.06%     
==========================================
  Files          98       98              
  Lines       13456    13457       +1     
  Branches       25       25              
==========================================
+ Hits        12655    12665      +10     
+ Misses        795      786       -9     
  Partials        6        6
Impacted Files Coverage Δ
src/serializers/fields.rs 94.44% <100.00%> (ø)
src/serializers/type_serializers/model.rs 95.03% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26fa27d...fac81b1. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented May 25, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #632 fix-model-subclasses (fac81b1) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 121 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@samuelcolvin
Copy link
Member Author

please review

@samuelcolvin samuelcolvin assigned dmontagu and unassigned adriangb May 25, 2023
@samuelcolvin samuelcolvin requested a review from dmontagu May 25, 2023 13:03
@dmontagu dmontagu merged commit 7dc970f into main May 25, 2023
@dmontagu dmontagu deleted the fix-model-subclasses branch May 25, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V2 Bug: Serializing with a type adapter behaves incorrectly for subclasses of union members
4 participants
@samuelcolvin @codecov-commenter @dmontagu @adriangb
0