Add error messages for json #637
Conversation
CodSpeed Performance ReportMerging #637 Summary
Benchmarks breakdown
|
src/errors/types.rs
Outdated
| @@ -541,8 +541,14 @@ impl ErrorType { | |||
| pub fn message_template_json(&self) -> &'static str { | |||
| match self { | |||
| Self::NoneRequired => "Input should be null", | |||
| Self::ListType => "Input should be a valid array", | |||
| Self::DataclassType { .. } => "Input should be an object", 8000 | |||
| Self::DictAttributesType => "Input should be a valid object or instance to extract fields from", | |||
There was a problem hiding this comment.
Should we explicitly add all of them, or it's fine to have the fallback?
There was a problem hiding this comment.
fine to have fallback.
I think this one can be removed add added to the "Input should be an object" message.
|
please review |
src/errors/types.rs
Outdated
| @@ -541,8 +541,14 @@ impl ErrorType { | |||
| pub fn message_template_json(&self) -> &'static str { | |||
| match self { | |||
| Self::NoneRequired => "Input should be null", | |||
| Self::ListType => "Input should be a valid array", | |||
| Self::DataclassType { .. } => "Input should be an object", | |||
| Self::DictAttributesType => "Input should be a valid object or instance to extract fields from", | |||
There was a problem hiding this comment.
fine to have fallback.
I think this one can be removed add added to the "Input should be an object" message.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 94.10% 93.85% -0.26%
==========================================
Files 99 99
Lines 13561 13640 +79
Branches 25 25
==========================================
+ Hits 12762 12802 +40
- Misses 793 832 +39
Partials 6 6
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Selected Reviewer: @dmontagu