8000 remove strict checks from models directly by samuelcolvin · Pull Request #647 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove strict checks from models directly #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2023
Merged

remove strict checks from models directly #647

merged 1 commit into from
May 29, 2023

Conversation

samuelcolvin
Copy link
Member
@samuelcolvin samuelcolvin commented May 29, 2023 •
edited by pydantic-hooky bot
Loading

related to pydantic/pydantic#5921

Selected Reviewer: @adriangb

@codecov-commenter
Copy link

Codecov Report

Merging #647 (3d6eada) into main (3bd718c) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   93.92%   93.89%   -0.03%     
==========================================
  Files          99       99              
  Lines       13668    13660       -8     
  Branches       25       25              
==========================================
- Hits        12837    12826      -11     
- Misses        825      828       +3     
  Partials        6        6
Impacted Files Coverage Δ
src/validators/model.rs 98.77% <ø> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd718c...3d6eada. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented May 29, 2023

CodSpeed Performance Report

Merging #647 model-strict (3d6eada) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 123 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@samuelcolvin
Copy link
Member Author

please review

@samuelcolvin samuelcolvin merged commit 679d590 into main May 29, 2023
@samuelcolvin samuelcolvin deleted the model-strict branch May 29, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelcolvin @codecov-commenter @adriangb
0