8000 support `from_attributes` at validation time by samuelcolvin · Pull Request #648 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support from_attributes at validation time #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2023
Merged

support from_attributes at validation time #648

merged 2 commits into from
May 29, 2023

Conversation

samuelcolvin
Copy link
Member

No description provided.

@codecov-commenter
Copy link
codecov-commenter commented May 29, 2023 •
edited
Loading

Codecov Report

Merging #648 (d370757) into main (3bd718c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   93.92%   93.88%   -0.04%     
==========================================
  Files          99       99              
  Lines       13668    13724      +56     
  Branches       25       25              
==========================================
+ Hits        12837    12885      +48     
- Misses        825      833       +8     
  Partials        6        6
Impacted Files Coverage Δ
src/url.rs 99.15% <100.00%> (ø)
src/validators/generator.rs 91.46% <100.00%> (+0.10%) ⬆️
src/validators/mod.rs 98.03% <100.00%> (+0.12%) ⬆️
src/validators/model_fields.rs 98.74% <100.00%> (+<0.01%) ⬆️
src/validators/union.rs 87.15% <100.00%> (+0.68%) ⬆️

... and 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd718c...d370757. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented May 29, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #648 validation-time-from_attributes (d370757) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 123 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

adriangb
adriangb approved these changes May 29, 2023
View reviewed changes
@samuelcolvin samuelcolvin enabled auto-merge (squash) May 29, 2023 20:08
@samuelcolvin samuelcolvin merged commit a6edba9 into main May 29, 2023
@samuelcolvin samuelcolvin deleted the validation-time-from_attributes branch May 29, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelcolvin @codecov-commenter @adriangb
0