8000 remove pydantic V1 comparisons from benchmark suite by davidhewitt · Pull Request #748 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove pydantic V1 comparisons from benchmark suite #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2023
Merged

remove pydantic V1 comparisons from benchmark suite #748

merged 2 commits into from
Jul 6, 2023

Conversation

davidhewitt
Copy link
Contributor
@davidhewitt davidhewitt commented Jul 6, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

Removes use of Pydantic V1 from the test suite now that V2 is released.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@codecov
Copy link
codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #748 (a1d1efd) into main (3a9c162) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          99       99           
  Lines       13929    13929           
  Branches       25       25           
=======================================
  Hits        13044    13044           
  Misses        879      879           
  Partials        6        6

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634087a...a1d1efd. Read the comment docs.

@davidhewitt
Copy link
Contributor Author

please review

@codspeed-hq
Copy link
codspeed-hq bot commented Jul 6, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #748 will not alter performances

Comparing dh/remove-pydantic-v1 (a1d1efd) with main (634087a)

Summary

✅ 126 untouched benchmarks

adriangb
adriangb approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member
@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the cleanup!

@davidhewitt davidhewitt merged commit fac2a40 into main Jul 6, 2023
@davidhewitt davidhewitt deleted the dh/remove-pydantic-v1 branch July 6, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@samuelcolvin samuelcolvin

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidhewitt @adriangb @samuelcolvin
0