8000 use github continue-on-error to avoid red CI with test-pydantic-integration by davidhewitt · Pull Request #817 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use github continue-on-error to avoid red CI with test-pydantic-integration #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

use github continue-on-error to avoid red CI with test-pydantic-integration #817

merged 1 commit into from
Jul 24, 2023

Conversation

davidhewitt
Copy link
Contributor
@davidhewitt davidhewitt commented Jul 24, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

At the moment CI is red on all runs because of test-pydantic-integration. I believe that using GHA's continue-on-error setting will have the same functionality as the alls-green check however will also mean the PR gets a green tick.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@codecov
Copy link
codecov bot commented Jul 24, 2023

Codecov Report

Merging #817 (f4a29c2) into main (f89c8b2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #817   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         102      102           
  Lines       14587    14587           
  Branches       25       25           
=======================================
  Hits        13639    13639           
  Misses        942      942           
  Partials        6        6

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89c8b2...f4a29c2. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented Jul 24, 2023

CodSpeed Performance Report

Merging #817 will not alter performance

Comparing dh/pydantic-integration (f4a29c2) with main (f89c8b2)

Summary

✅ 135 untouched benchmarks

@davidhewitt
Copy link
Contributor Author

Looks like the PR still has a red cross, but the actions CI status is successful:

image

https://github.com/pydantic/pydantic-core/actions/runs/5645640678

image

@davidhewitt
Copy link
Contributor Author

More importantly, people won't get emails notifying of CI run failure.

@davidhewitt
Copy link
Contributor Author

please review

samuelcolvin
samuelcolvin approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member
@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelcolvin
Copy link
Member

doesn't seem to make that much difference? We still get the cross, so the PR still shows as failing.

@davidhewitt
Copy link
Contributor Author

doesn't seem to make that much difference? We still get the cross, so the PR still shows as failing.

As per comments above, the red cross is still there but the actions run succeeds so no email notifying of failure.

@davidhewitt davidhewitt merged commit 7cbbd74 into main Jul 24, 2023
@davidhewitt davidhewitt deleted the dh/pydantic-integration branch July 24, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin approved these changes

Assignees

@dmontagu dmontagu

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidhewitt @samuelcolvin @dmontagu
0