8000 Build wheels for arm64 Windows by messense · Pull Request #856 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Build wheels for arm64 Windows #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

Build wheels for arm64 Windows #856

merged 1 commit into from
Aug 7, 2023

Conversation

messense
Copy link
Contributor
@messense messense commented Aug 6, 2023

Change Summary

Add CI configuration for cross compiling arm64 Windows wheels. Note that arm64 Windows only has official Python support since 3.11.

Example run: https://github.com/messense/pydantic-core/actions/runs/5776288091/job/15655238295

Related issue number

fix #840

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codecov
Copy link
codecov bot commented Aug 6, 2023

Codecov Report

Merging #856 (1dafdbc) into main (ca1055b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         102      102           
  Lines       14609    14609           
  Branches       25       25           
=======================================
  Hits        13663    13663           
  Misses        940      940           
  Partials        6        6

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1055b...1dafdbc. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented Aug 6, 2023

CodSpeed Performance Report

Merging #856 will degrade performances by 47.24%

Comparing messense:windows-aarch64 (1dafdbc) with main (ca1055b)

Summary

🔥 6 improvements
❌ 9 regressions
✅ 120 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main messense:windows-aarch64 Change
❌ test_complete_core_lax 1.1 ms 1.4 ms -25.04%
❌ test_complete_core_error 7.8 ms 8.8 ms -11.66%
❌ test_core_string_lax_wrong 40 µs 59.7 µs -33.04%
🔥 test_core_python 46 µs 40.6 µs +13.23%
🔥 test_date_from_str 25.8 µs 22.5 µs +14.61%
🔥 test_core_future_str 25.4 µs 22 µs +15.35%
❌ test_strict_union_error_core 42.9 µs 48.5 µs -11.54%
🔥 test_date_from_datetime 38.8 µs 33.7 µs +15.29%
❌ test_dont_raise_error_no_info 22.9 µs 26.3 µs -13.15%
❌ test_dont_raise_error 25.5 µs 36.9 µs -30.96%
❌ test_with_default 36.5 µs 43.4 µs -15.8%
❌ test_int_error 74.1 µs 96.5 µs -23.25%
❌ test_tagged_union_int_keys_python 30.3 µs 57.5 µs -47.24%
🔥 test_core_model_py_extra 67.9 µs 56.7 µs +19.93%
🔥 test_model_exclude_unset_false 65.7 µs 52.8 µs +24.58%

davidhewitt
davidhewitt approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor
@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt merged commit d6ba6e6 into pydantic:main Aug 7, 2023
@messense messense deleted the windows-aarch64 branch August 7, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to install on Windows ARM
2 participants
@messense @davidhewitt
0