8000 Update to speedate 0.12 by davidhewitt · Pull Request #887 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update to speedate 0.12 #887 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2023
Merged

Update to speedate 0.12 #887

merged 2 commits into from
Aug 15, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Updates to speedate 0.12.0, which changes timestamp serialization to always format the fractional seconds (if present) as microseconds.

Related issue number

Fixes pydantic/pydantic#6761

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codecov
Copy link
codecov bot commented Aug 15, 2023

Codecov Report

Merging #887 (97bac31) into main (26453d5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files         104      104           
  Lines       15485    15485           
  Branches       25       25           
=======================================
  Hits        14523    14523           
  Misses        956      956           
  Partials        6        6

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26453d5...97bac31. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented Aug 15, 2023

CodSpeed Performance Report

Merging #887 will degrade performances by 24.62%

Comparing dh/speedate-0.12 (97bac31) with main (26453d5)

Summary

🔥 2 improvements
❌ 1 regressions
✅ 135 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/speedate-0.12 Change
🔥 test_complete_core_lax 1.8 ms 1.4 ms +29.24%
🔥 test_small_class_core_model 53.5 µs 47.7 µs +12.12%
❌ test_dont_raise_error 29.5 µs 39.1 µs -24.62%

@davidhewitt davidhewitt merged commit 0a072b0 into main Aug 15, 2023
@davidhewitt davidhewitt deleted the dh/speedate-0.12 branch August 15, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

model_dump_json removes (all) irrelevant milliseconds.
2 participants
@davidhewitt @adriangb
0