8000 limit test requirements so that all platforms can build by davidhewitt · Pull Request #892 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

limit test requirements so that all platforms can build #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2023
Merged

limit test requirements so that all platforms can build #892

merged 1 commit into from
Aug 16, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

At the moment we have CI failures which seem to be caused by issues with pandas, numpy and pytest-codspeed pulling in either themselves or requirements on platforms which can't easily build them without a lot of faff.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Aug 16, 2023
@codecov
Copy link
codecov bot commented Aug 16, 2023

Codecov Report

Merging #892 (5f96178) into main (a2b531a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files         105      105           
  Lines       15249    15249           
  Branches       25       25           
=======================================
  Hits        14302    14302           
  Misses        941      941           
  Partials        6        6

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b531a...5f96178. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented Aug 16, 2023

CodSpeed Performance Report

Merging #892 will degrade performances by 23.1%

Comparing dh/test-requirements (5f96178) with main (a2b531a)

Summary

🔥 2 improvements
❌ 1 regressions
✅ 135 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/test-requirements Change
❌ test_complete_core_lax 1.4 ms 1.8 ms -23.1%
🔥 test_dont_raise_error 39.8 µs 29.3 µs +36.08%
🔥 test_variable_tuple 38.7 µs 34.3 µs +12.81%

@dmontagu dmontagu merged commit e56491e into main Aug 16, 2023
@dmontagu dmontagu deleted the dh/test-requirements branch August 16, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees
No one assigned
Labels
Full Build cause CI to do a full build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @dmontagu
0