8000 remove dict validation macro by samuelcolvin · Pull Request #917 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove dict validation macro #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

remove dict validation macro #917

merged 1 commit into from
Aug 23, 2023

Conversation

samuelcolvin
Copy link
Member

Remove the build_validate macro from dict validation by using a generic.

@codecov
Copy link
codecov bot commented Aug 23, 2023

Codecov Report

Merging #917 (dec9400) into main (a5cb738) will increase coverage by 0.01%.
The diff coverage is 95.83%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   93.79%   93.81%   +0.01%     
==========================================
  Files         105      105              
  Lines       15364    15366       +2     
  Branches       25       25              
==========================================
+ Hits        14411    14415       +4     
+ Misses        947      945       -2     
  Partials        6        6
Files Changed Coverage Δ
src/validators/dict.rs 87.96% <95.83%> (+2.11%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cb738...dec9400. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented Aug 23, 2023

CodSpeed Performance Report

Merging #917 will degrade performances by 27.98%

Comparing remove-dict-macro (dec9400) with main (a5cb738)

Summary

🔥 1 improvements
❌ 1 regressions
✅ 136 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-dict-macro Change
🔥 test_complete_core_lax 1.8 ms 1.4 ms +29.82%
❌ test_dont_raise_error 29.2 µs 40.6 µs -27.98%

@samuelcolvin
Copy link
Member Author

looking at codspeed the relevant benchmarks related to dicts don't seem to have been effected at all.

davidhewitt
davidhewitt approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor
@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidhewitt davidhewitt merged commit 4a1ef3a into main Aug 23, 2023
@davidhewitt davidhewitt deleted the remove-dict-macro branch August 23, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelcolvin @davidhewitt
0