8000 Populate defs from defs schema by adriangb · Pull Request #972 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Populate defs from defs schema #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 18, 2023
Merged

Populate defs from defs schema #972

merged 10 commits into from
Sep 18, 2023

Conversation

adriangb
Copy link
Member

@adriangb adriangb force-pushed the < 10000 span class="commit-ref user-select-contain"> populate-defs-from-defs-schema branch from fbdc9d9 to f8f76bb Compare September 18, 2023 14:21
@codspeed-hq
Copy link
codspeed-hq bot commented Sep 18, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #972 will not alter performance

Comparing populate-defs-from-defs-schema (0866bc1) with main (1d10238)

Summary

✅ 138 untouched benchmarks

davidhewitt
davidhewitt approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor
@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me as a way to avoid complexity of refs being global, thus simplifying pydantic boot time.

@adriangb adriangb marked this pull request as ready for review September 18, 2023 18:27
@adriangb adriangb enabled auto-merge (squash) September 18, 2023 18:29
@codecov
Copy link
codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Merging #972 (0866bc1) into main (1d10238) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   93.78%   93.74%   -0.05%     
==========================================
  Files         105      105              
  Lines       15539    15530       -9     
  Branches       25       25              
==========================================
- Hits        14574    14558      -16     
- Misses        959      966       +7     
  Partials        6        6
Files Changed Coverage Δ
python/pydantic_core/core_schema.py 96.77% <ø> (ø)
src/definitions.rs 96.36% <ø> (ø)
src/serializers/shared.rs 79.88% <ø> (-0.76%) ⬇️
src/validators/mod.rs 95.03% <ø> (-0.09%) ⬇️
src/serializers/type_serializers/definitions.rs 93.33% <100.00%> (+0.11%) ⬆️
src/validators/definitions.rs 89.47% <100.00%> (-6.14%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d10238...0866bc1. Read the comment docs.

@adriangb adriangb merged commit a17e9b6 into main Sep 18, 2023
@adriangb adriangb deleted the populate-defs-from-defs-schema branch September 18, 2023 20:27
@davidhewitt davidhewitt mentioned this pull request Sep 19, 2023
Closed
This was referenced Jun 3, 2024
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriangb @davidhewitt
0