8000 Add support for hiding input in errors and json by sydney-runkle · Pull Request #973 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for hiding input in errors and json #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 20, 2023

Conversation

sydney-runkle
Copy link
Contributor
@sydney-runkle sydney-runkle commented Sep 18, 2023

Summary

Add support for hiding input in errors and json
Still to do: add unit tests, clean up code

Related issue number

Fix #7461

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@codecov
Copy link
codecov bot commented Sep 18, 2023

Codecov Report

Merging #973 (e5406d2) into main (157a643) will decrease coverage by 0.01%.
The diff coverage is 96.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
- Coverage   93.11%   93.11%   -0.01%     
==========================================
  Files         106      106              
  Lines       15791    15802      +11     
  Branches       25       25              
==========================================
+ Hits        14704    14714      +10     
- Misses       1081     1082       +1     
  Partials        6        6              
Files Changed Coverage Δ
src/errors/validation_exception.rs 91.60% <96.29%> (-0.02%) ⬇️
src/build_tools.rs 81.63% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157a643...e5406d2. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented Sep 18, 2023

CodSpeed Performance Report

Merging #973 will not alter performance

Comparing hide-input-validation-error (e5406d2) with main (157a643)

Summary

✅ 138 untouched benchmarks

@sydney-runkle
Copy link
Contributor Author

Please review

@sydney-runkle sydney-runkle marked this pull request as ready for review September 20, 2023 11:50
@sydney-runkle sydney-runkle changed the title Draft: add support for hiding input in errors and json Add support for hiding input in errors and json Sep 20, 2023
@davidhewitt
Copy link
Contributor

please update

Copy link
Member
@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0