8000 use `TypedDict` from `typing_extensions` on <3.12 by davidhewitt · Pull Request #978 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use 8000 TypedDict from typing_extensions on <3.12 #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2023
Merged

use TypedDict from typing_extensions on <3.12 #978

merged 1 commit into from
Sep 20, 2023

Conversation

davidhewitt
Copy link
Contributor
@davidhewitt davidhewitt commented Sep 20, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

As per title.

Related issue number

Closes #837
Also related to experiments in pydantic/pydantic#7525

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@davidhewitt
Copy link
Contributor Author

please review

@codecov
Copy link
codecov bot commented Sep 20, 2023

Codecov Report

Merging #978 (6593653) into main (157a643) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 40.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   93.11%   93.10%   -0.02%     
==========================================
  Files         106      106              
  Lines       15791    15794       +3     
  Branches       25       26       +1     
==========================================
+ Hits        14704    14705       +1     
- Misses       1081     1082       +1     
- Partials        6        7       +1
Files Changed Coverage Δ
python/pydantic_core/core_schema.py 96.54% <40.00%> (-0.24%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157a643...6593653. Read the comment docs.

@codspeed-hq
Copy link
codspeed-hq bot commented Sep 20, 2023

CodSpeed Performance Report

Merging #978 will not alter performance

Comparing dh/typed-dict (6593653) with main (157a643)

Summary

✅ 138 untouched benchmarks

@adriangb adriangb merged commit b8d3b95 into main Sep 20, 2023
@adriangb adriangb deleted the dh/typed-dict branch September 20, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

@hramezani hramezani hramezani approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatch in TypedDict from typing versioning between pydantic and pydantic-core
4 participants
@davidhewitt @adriangb @hramezani @dmontagu
0