Support indirect definition references #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
+ Coverage 89.73% 89.78% +0.04%
==========================================
Files 106 106
Lines 16380 16429 +49
Branches 35 35
==========================================
+ Hits 14699 14751 +52
+ Misses 1674 1671 -3
Partials 7 7
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #1130 will degrade performances by 14.43%Comparing Summary
Benchmarks breakdown
|
|
Looks great! |
adriangb
approved these changes
Dec 21, 2023
davidhewitt
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes certain usage patterns work better in pydantic, e.g., making TypeAliasType references to other TypeAliasType's. I think we may want to optimize out reference chains at some point, but I don't think that should stop us from merging this now since this only makes more schemas acceptable, and doesn't affect any existing use of Pydantic (and the Pydantic PR I will open that makes use of this won't affect any currently-working usage, it will just allow some schemas that currently would raise schema-building errors).