Fix generate_self_schema for Python 3.12+ #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1299 will not alter performanceComparing Summary
|
sydney-runkle
approved these changes
May 22, 2024
|
@JelleZijlstra it's worth noting that I have no idea what parts may be broken under 3.14 due to the PyO3 layer - we can try to add patches to PyO3 if needed but hopefully the majority works. If in doubt you might want to try this branch which at least attempts to catch up with 3.13: PyO3/pyo3#4184 |
|
Thanks! Yes, when I tried locally I got an error telling me to use an env var that tries to use the stable ABI, but then I got the error that this PR fixes. I'll look into it some more later. |
15 tasks
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference: https://github.com/python/cpython/blob/8c96850161da23ad2b37551d2a89c7d4716fe024/Lib/typing.py#L916
Ran into this trying to install pydantic on 3.14.
Change Summary
Related issue number
Checklist
pydantic-core(except for expected changes)