8000 fix: submodel fields with wrap validator affect smart union selection by weiliddat · Pull Request #1700 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: submodel fields with wrap validator affect smart union selection #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

fix: submodel fields with wrap validator affect smart union selection #1700

merged 2 commits into from
May 18, 2025

Conversation

weiliddat
Copy link
Contributor
@weiliddat weiliddat commented Apr 18, 2025 •
edited by pydantic-hooky bot
Loading

Change Summary

  • Keep fields_set_count state when validating submodels

Related issue number

Fixes pydantic/pydantic#11752

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

weiliddat
weiliddat commented Apr 18, 2025
View reviewed changes
@weiliddat
Copy link
Contributor Author

please review

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Apr 18, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1700 will not alter performance

Comparing weiliddat:fix/wrap-validator-smart-union (c697525) with main (334a9b0)

Summary

✅ 157 untouched benchmarks

@weiliddat weiliddat requested a review from Viicos April 25, 2025 18:00
@weiliddat
Copy link
Contributor Author

Just a ping in case it slipped your notifications @Viicos @davidhewitt

davidhewitt
davidhewitt approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor
@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for the delay!

@davidhewitt< 8000 /a> davidhewitt merged commit 4375d6a into pydantic:main May 18, 2025
28 of 29 checks passed
This was referenced Jun 14, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@Viicos Viicos Awaiting requested review from Viicos

Assignees

@davidhewitt davidhewitt

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WrapValidator annotation changes smart union score
3 participants
@weiliddat @davidhewitt @Viicos
0