8000 drop serde-json `preserve_order` feature by davidhewitt · Pull Request #1724 · pydantic/pydantic-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 drop serde-json preserve_order feature #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

drop serde-json preserve_order feature #1724

merged 2 commits into from
May 28, 2025

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Observed in pydantic/pydantic#7424 (comment), we currently use preserve_order feature of serde-json. This preserves ordering of values during parse.

This should not be needed since we moved to jiter for parsing.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1724 will not alter performance

Comparing dh/no-serde-preserve-order (5cb6078) with main (22d34a7)

Summary

✅ 157 untouched benchmarks

Viicos
Viicos reviewed May 28, 2025
View reviewed changes
Viicos
Viicos approved these changes May 28, 2025
View reviewed changes
Copy link
Member
@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt merged commit 238c1c7 into main May 28, 2025
28 of 29 checks passed
@davidhewitt davidhewitt deleted the dh/no-serde-preserve-order branch May 28, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @Viicos
0