Fix auto-unwrapping in the multiomics example. #472
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a line to prevent auto-unwrapping.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 91.19% 91.18% -0.02%
==========================================
Files 67 67
Lines 7794 7796 +2
==========================================
+ Hits 7108 7109 +1
- Misses 686 687 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have updated config.py with a better random seed. Previous seed performs very bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix auto-unwrapping in the multiomics example.
Description
When running the multiomics cancer classification example (MOGONET), setting
cfg.DATASET.NUM_MODALITIES=1leads to an error in line 154:I also changed the random seed in
config.py. The previous seed performs much worse than the reported results in the original paper. New seed performs much closer.In this case,
optimizeris intended to be a list of optimizers; however, the program automatically unwraps the list and returns only an optimizer object if there is only one optimizer in the list. This triggers the error when we use the modality index to fetch an optimizer in the list.Status
Ready
Types of changes
docsmanually updated for new API.