8000 Add a new example for video feature vector input by xianyuanliu · Pull Request #293 · pykale/pykale · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a new example for video feature vector input #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

Add a new example for video feature vector input #293

wants to merge 63 commits into from

Conversation

xianyuanliu
Copy link
Member
@xianyuanliu xianyuanliu commented Jan 26, 2022 •
edited
Loading

Description

This PR follows PR #291 and #292, upgrading DA Trainers for feature vector input. Trainers on video image input and video feature vector input have two main differences below:

  1. Three modality choices in image input: RGB, Flow and joint (RGB+Flow), due to no Audio available now; Five in feature vector: RGB, Flow, Audio, joint and all (RGB+Flow+Audio).
  2. One class type in image input: verb; Two in feature: verb, verb+noun.

The main changes are below:

  1. Add Audio branch into the pipeline.
  2. Update optimizer work with SGD and ADAM.
  3. Add adaptive choice into source/target dataset sampling.
  4. Add JSON logger for EPIC UDA challenge.
  5. Reduce dummy network dimension in test_video_domain_adapter.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • In-line docstrings updated.
  • Source for documentation at docs manually updated for new API.

@xianyuanliu
update .gitignore
7ccd345
@xianyuanliu
update .gitignore
d955f73
@xianyuanliu
change root dir
1cecdf2
@xianyuanliu
add EPIC100DatasetAccess
f9d0577
@xianyuanliu
change transform_kind to transform
046ef98
@xianyuanliu
add NUM_SEGMENTS
77f1b0f
@xianyuanliu
add INPUT_TYPE
8a8581b
@xianyuanliu
add functions in VideoDatasetAccess for feature vector input
23b0e8e
@xianyuanliu
add get_class_type
f993f8d
@xianyuanliu
add CLASS_TYPE
60951d4
@xianyuanliu
change num_classes to dict_num_classes
76f3e72
@xianyuanliu
update ClassNetVideo for dual-class task
feaf72a
@xianyuanliu
update test
f5bc2b7
@xianyuanliu
Merge branch 'main' into add_feature_vector_dataloader
63c5be9
@xianyuanliu
change output folder to tb_logs
f89d8fc
@xianyuanliu
add get_class_type test
b845a88
@xianyuanliu
update test_video_access
ef74b72
@xianyuanliu
update config
b43802c
@xianyuanliu
test bug fixes
ba6f5c5
@xianyuanliu
add VideoFeatureRecord in Videos.py & improve doc
bdf9cbb
@xianyuanliu
add epic100 test & bug fixes
3ea4678
@xianyuanliu
test bug fixes
1540051
@xianyuanliu
test bug fixes
de0e6cd
@xianyuanliu
add BaseAdaptTrainerVideo
cf1638b
@xianyuanliu
bug fixes
a2b3ce8
@xianyuanliu
add CLASS_TYPE
4470413
@xianyuanliu
add conditional function for class type
37aeaac
@xianyuanliu
add audio dataset into VideoDataset
1e625dd
@xianyuanliu
add frame_per_segment warning for feature vector input
56430a3
@xianyuanliu
add num_worker
8acdafa
@codecov-commenter
Copy link
codecov-commenter commented Jan 27, 2022 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 90.52248% with 78 lines in your changes missing coverage. Please review.

Project coverage is 92.31%. Comparing base (e42b4ec) to head (2f7770f).
Report is 1492 commits behind head on main.

Files with missing lines Patch % Lines
kale/pipeline/video_domain_adapter.py 91.01% 40 Missing ⚠️
kale/loaddata/video_multi_domain.py 67.85% 18 Missing ⚠️
kale/loaddata/videos.py 90.00% 7 Missing ⚠️
kale/loaddata/multi_domain.py 53.84% 6 Missing ⚠️
kale/loaddata/video_access.py 94.44% 4 Missing ⚠️
kale/embed/video_feature_extractor.py 93.10% 2 Missing ⚠️
kale/embed/attention_cnn.py 98.38% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   92.98%   92.31%   -0.68%     
==========================================
  Files          45       45              
  Lines        4635     5163     +528     
==========================================
+ Hits         4310     4766     +456     
- Misses        325      397      +72

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xianyuanliu xianyuanliu marked this pull request as ready for review January 29, 2022 04:23
@github-actions
Copy link
Contributor
github-actions bot commented Oct 7, 2022

This pull request has been automatically marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Oct 7, 2022
@xianyuanliu xianyuanliu added Stale and removed Stale labels Dec 9, 2024
@github-actions github-actions bot removed the Stale label Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale due to lack of activity.

@github-actions github-actions bot added Stale and removed Stale labels Jan 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale due to lack of activity.

@github-actions github-actions bot added Stale and removed Stale labels Mar 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale due to lack of activity.

@github-actions github-actions bot added Stale and removed Stale labels Apr 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale due to lack of activity.

@github-actions github-actions bot added Stale and removed Stale labels Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuo-zhou shuo-zhou Awaiting requested review from shuo-zhou

@haipinglu haipinglu Awaiting requested review from haipinglu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new feature New feature/module (including request)
Projects
PyKale v0.2.0
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xianyuanliu @codecov-commenter

Footer

© 2025 GitHub, Inc.
0