Fix bug in trigger parsing #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug when comparison of triggers didn't work after parsing when having stop-trigger
Parsing with different versions now handled better
New test comparing a parsed xml and the object, done for all examples and versions. Can be used a regression test for all xmls
tmIdiada
reviewed
Jun 26, 2025
examples/generator/CCRb.py
Outdated
| import os | ||
|
|
||
| import numpy as np | ||
|
|
||
| from scenariogeneration import prettyprint, xosc |
There was a problem hiding this comment.
Is this line needed? You have this import in line 35
There was a problem hiding this comment.
interesting, Isort couln't handle this properly apparently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing some parsing bugs related to openscenario version
adding more tests for parsing